Enable limitless/ZkCounter for all acceptance tests#2351
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2351 +/- ##
=============================================
- Coverage 61.13% 10.18% -50.96%
=============================================
Files 436 436
Lines 17362 17362
Branches 1908 1908
=============================================
- Hits 10615 1769 -8846
- Misses 6088 15593 +9505
+ Partials 659 0 -659
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
gauravahuja
force-pushed
the
gauravahuja/at_zkcounter
branch
from
be2b6b8 to
d967374
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
...-sequencer/acceptance-tests/src/test/kotlin/linea/plugin/acc/test/ExcludedPrecompilesTest.kt
Outdated
Show resolved
Hide resolved
gauravahuja
force-pushed
the
gauravahuja/at_zkcounter
branch
from
0740377 to
ece00f7
Compare
...-sequencer/acceptance-tests/src/test/kotlin/linea/plugin/acc/test/ExcludedPrecompilesTest.kt
Show resolved
Hide resolved
...equencer/acceptance-tests/src/test/kotlin/linea/plugin/acc/test/TransactionTraceLimitTest.kt
Show resolved
Hide resolved
fab-10
left a comment
fab-10
left a comment
There was a problem hiding this comment.
As I said in response so @letypequividelespoubelles, the 2 test still on the ZkTracer either should be adapted to work with the ZkCounter or if not relevant anymore, disabled or removed
...-sequencer/acceptance-tests/src/test/kotlin/linea/plugin/acc/test/ExcludedPrecompilesTest.kt
Show resolved
Hide resolved
The |
So the test is still relevant, and should be adapted to work with the limitless mode |
|
@letypequividelespoubelles I don't have much context on the tests so could you help adapt them to limitless mode? |
4 participants
This PR implements issue(s) #2249
Checklist
Note
Low Risk
Changes are limited to acceptance-test CLI configuration and should only affect test behavior/coverage, with low risk to production code.
Overview
Updates Linea sequencer acceptance-test defaults to run with
--plugin-linea-limitless-enabled=trueand usemoduleLimitsLimitless.tomlas the standard module-limits configuration.Tests that validate strict/excluded-precompile behavior (
TransactionTraceLimitTest,ExcludedPrecompilesTest) now explicitly disable limitless and point to the appropriate strict/no-limits module limit files to preserve their expected assertions.Written by Cursor Bugbot for commit 58087dc. This will update automatically on new commits. Configure here.